fix: Use uniquely named local variables #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsumners-nr
reviewed
Jul 1, 2025
Contributor
jsumners-nr
left a comment
jsumners-nr
left a comment
There was a problem hiding this comment.
Thank you for adding tests. Very disappointing the original author doesn't see the value. I opened #15 that cherry-picks the original commit from upstream. I think we'll have an easier time if we merge that first and then rebase this PR on top of it.
Contributor
|
Ugh. My PR isn't going to work because it needs tests. Can you back out our change to the same file, and: git remote add datadog [email protected]:DataDog/orchestrion-js.git
git cherry-pick datadog/main 1794b4a81bdc851e1730cf667663f24cf14146a4on your branch. |
timfish
force-pushed
the
fix/no-clashing-locals
branch
from
b8182ca to
122e4de
Compare
Member
Author
We added code snapshot tests for the JavaScript API but the upstream repo doesn't have a JavaScript API or any snapshot tests. I consider the snapshot tests a bit annoying in some ways because they don't actually test the functionality. |
jsumners-nr
approved these changes
Jul 1, 2025
bizob2828
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a copy of @simon-id PR to the upstream project
tracedto__apm$tracednodejs/orchestrion-js#21